Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This publishes the OpenCompany side of the shared Lua-core refactor.
It updates OpenCompany to consume the new shared Lua catalog/docs/bridge logic extracted into
opencompanyapp/integration-core:LuaApiDocGeneratornow delegates namespace/catalog/doc rendering to shared core classesLuaBridgenow delegates routing and call logging to the shared core bridgeOpenCompanyLuaToolInvokeradapts OpenCompany'sToolRegistryto the shared bridge contractToolRegistryis now registered as a singleton so built-in providers survive container resolution and the Lua docs/bridge see the full app catalog consistentlyThis branch also includes the existing local changes that were already present in the worktree when I started, per request.
Dependency
Depends on:
Why
The goal is to keep package boundaries small and clean:
integration-coreowns shared tool contracts and shared PHP-side Lua logicintegration-*packages remain actual integrationslua-sandboxremains native runtime onlyprism-relayremains provider/model normalization onlyValidation
Ran:
php artisan test tests/Feature/LuaApiDocGeneratorTest.php tests/Feature/LuaBridgeTest.php tests/Feature/Tools/LuaExecTest.phpAll passed on this branch.